Echo JS 0.11.0


reicher89 1074 days ago. link 1 point
Thanks for the feedback... or criticism I guess.

A plugin doesn't have to be huge to be good. Maybe provide some concrete tips on how to 'refactor' and make it better? Nothing is perfect on the first release. It's easy to say something sucks but it's another to actually provide constructive feedback. Also, there's no way this could be done 'in a few simple lines', if so you could have posted those couple of lines and a link to a demo that replicates it perfectly in the same amount of time it took you to write that comment. Also, how does this not provide value? One of the most critical parts of a web application is communicating messages and updates with a user, and this accomplishes that to certain extent.

It's so easy to criticize just to sound smart... but not a single suggestion/tip? Very disappointed in you folks...
sylvainpv 1074 days ago. link 2 points
Here are some tips:
- do not override body inline style or disable scroll, this is a very bad practice than can break existing stuff
- provide a stylesheet instead of dozens of inline style properties
- validate your code with a linter, like JSLint
- provide a minified version

Sorry to be harsh but I agree with others. You shoukd know that there are already _LOTS_ of notification libraries out there that are, technically speaking, much better designed that this one. That does not mean you should give up, this is a great opportunity to improve your skills. But be aware that this is a news site consulted by experienced developers who expect to find projects technically impeccable. Maybe it was too soon to publish here.
reicher89 1074 days ago. link 1 point
Ok I won't post here again unless my post is more advanced, unique, and impeccable.
Thanks very much for the suggestions and advice, much appreciated.
sady92 1074 days ago. link 0 point
mine was not a criticism, i was just pointing out that the whole library was written in a procedural style, and that you can use JS objects for the configuration.

If for example i wanted to edit the plugin, i would need to do that directly from the library, but there should be an easier way, let say build a constructor and pass an config object.

No one is flaming on you, and whatever suggestion/criticism you receive should be for good, we are not saying "get out of here", we just said you could do a better job based on our experience.

You wont never stop learning new things for as long as you live :).
ferahl 1075 days ago. link 1 point
Must have a lot of friends. I agree this could be done in a few simple lines, people become too dependent on these type of plugins which don't provide value
sbruchmann 1075 days ago. link 1 point
As @sady92 already had pointed out, this plugin does indeed have a huge need for refactoring, as most of the code is redundant and can be simplified.

Beside that, this plugin does nothing special I couldn’t do with a few lines of HTML, CSS and JS myself. Why are there so many upvotes then? Something smells fishy here…
sady92 1075 days ago. link 1 point
I had a look at your plugin code, i would say it has a huge need of refactoring, i believe it can be simplified way more than as it is right now.