Echo JS 0.11.0

<~>
sylvainpv 3061 days ago. link parent 2 points
Here are some tips:
- do not override body inline style or disable scroll, this is a very bad practice than can break existing stuff
- provide a stylesheet instead of dozens of inline style properties
- validate your code with a linter, like JSLint
- provide a minified version

Sorry to be harsh but I agree with others. You shoukd know that there are already _LOTS_ of notification libraries out there that are, technically speaking, much better designed that this one. That does not mean you should give up, this is a great opportunity to improve your skills. But be aware that this is a news site consulted by experienced developers who expect to find projects technically impeccable. Maybe it was too soon to publish here.

Replies

reicher89 3061 days ago. link 1 point
Ok I won't post here again unless my post is more advanced, unique, and impeccable.
Thanks very much for the suggestions and advice, much appreciated.
sady92 3060 days ago. link 0 point
mine was not a criticism, i was just pointing out that the whole library was written in a procedural style, and that you can use JS objects for the configuration.

If for example i wanted to edit the plugin, i would need to do that directly from the library, but there should be an easier way, let say build a constructor and pass an config object.

No one is flaming on you, and whatever suggestion/criticism you receive should be for good, we are not saying "get out of here", we just said you could do a better job based on our experience.

You wont never stop learning new things for as long as you live :).