Would work on expanding the test harness... the application breakdown may not lead to good testing structure. Also, I would recommend having the test next to the module being tested as a general rule.
On the latter part, some projects (looking at you ASP.Net) will break up structure into mirrored trees... you'll have a controller, view, js, etc all with the same name sitting in different directories... the same for tests (in this case), where you wind up hunting across directories looking for things that are the same contextual concern. I prefer to see a structure based on the context/feature concern where the different types of files are next to each other in the directory, so they're easy to navigate between when working in that context and this includes tests imo.
I didn't dig into the code, so can't comment much on what is or isn't in place. I'm generally not a big fan of ORMs in general, especially in a scripted language, as you can usuaally do type inference from a simpler mapping from direct SQL. With a taggeed template string processor in the case of JS.
As for Joi, tend to prefer Zod myself, as it has *much* better TS inference imo.
tracker1 245 days ago. link 1 point ▲ ▼